Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass grad scaler from trainer to pipeline #1996

Merged
merged 4 commits into from
May 25, 2023
Merged

pass grad scaler from trainer to pipeline #1996

merged 4 commits into from
May 25, 2023

Conversation

terrancewang
Copy link
Contributor

No description provided.

@terrancewang terrancewang requested a review from tancik May 24, 2023 23:13
@brentyi brentyi changed the title pass grad sclaer from trainer to pipeline pass grad scaler from trainer to pipeline May 24, 2023
@@ -235,6 +236,7 @@ def __init__(
test_mode: Literal["test", "val", "inference"] = "val",
world_size: int = 1,
local_rank: int = 0,
grad_scaler: Optional[GradScaler] = None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add grad_scalar to arg doc

Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tancik tancik merged commit a8bce87 into main May 25, 2023
4 checks passed
@tancik tancik deleted the pipeline_grad_scaler branch May 25, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants