Add Metadata Handling to Cameras
Collation Function
#2001
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue in the
nerfstudio_collate
function where the metadata ofCameras
objects is not properly accounted for during batch processing.In the existing implementation, the metadata of
Cameras
objects is not included during collation, leading to the assignment ofNone
to the metadata field. This may cause downstream issues for components that rely on this metadata for processing.The proposed changes aim to ensure that the metadata of each
Cameras
object in a batch is properly collated. The updates involve the creation of a metadata dictionary that collates the metadata from eachCameras
object in the batch. This dictionary is then passed to theCameras
constructor during batch assembly.The changes ensure that all
Cameras
objects have the same metadata keys before proceeding with the collation. This ensures consistency across the batch and prevents potential errors from occurring due to mismatched or missing metadata keys.