Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metashape_utils.py #2011

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Conversation

henrypearce4D
Copy link
Contributor

Changed the ValueError message when using a camera.xml that contains multiple sensors. Per-frame intrinsics can be defined, the previous message said that they were not supported.

Changed the ValueError message when using a camera.xml that contains multiple sensors. Per-frame intrinsics can be defined, the previous message said that they were not supported.
Copy link
Collaborator

@brentyi brentyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me!

@brentyi brentyi merged commit 293d8f3 into nerfstudio-project:main Jun 2, 2023
4 checks passed
@f-dy
Copy link
Contributor

f-dy commented Jun 7, 2023

I don't understand: the previous message was correct, and it was triggered only when using several camera_model values in the metashape project (eg fisheye + perspective).

The limitation does not come from this utility but from nerfstudio itself, see here: "Per-frame camera_model is not supported." - which is exactly the sentence I used in the error message.

@f-dy
Copy link
Contributor

f-dy commented Jun 7, 2023

@henrypearce4D @brentyi I think this should be reverted, as the new message is more confusing.

@brentyi
Copy link
Collaborator

brentyi commented Jun 7, 2023

Yeah, on a re-read the original error message makes sense. @henrypearce4D can you comment/confirm?

@henrypearce4D
Copy link
Contributor Author

henrypearce4D commented Jun 7, 2023

@brentyi -
@f-dy Is correct, it can be reverted perhaps with a little clarification added as another user recently mentioned this was a little confusing;

"nerfstudio does not support per-frame camera_model types."

"Only one camera type can be used: frame, fisheye or spherical (perspective, fisheye or equirectangular)."

@henrypearce4D henrypearce4D deleted the patch-2 branch June 8, 2023 12:11
@brentyi
Copy link
Collaborator

brentyi commented Jun 9, 2023

@henrypearce4D that sounds reasonable to me!

@henrypearce4D henrypearce4D restored the patch-2 branch June 9, 2023 19:29
henrypearce4D added a commit to henrypearce4D/nerfstudio that referenced this pull request Jun 9, 2023
brentyi pushed a commit that referenced this pull request Jun 9, 2023
Reverted back to the original error message with some extra clarification added.

cc #2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants