Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kwargs to dataparser outputs #2053

Merged
merged 2 commits into from
Jun 10, 2023
Merged

Add kwargs to dataparser outputs #2053

merged 2 commits into from
Jun 10, 2023

Conversation

maturk
Copy link
Collaborator

@maturk maturk commented Jun 9, 2023

I found in my research that I needed some additional kwargs beyond "split" to generate dataparser outputs. Added kwargs as optional arguments.

tancik
tancik approved these changes Jun 10, 2023
View reviewed changes
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tancik tancik enabled auto-merge (squash) June 10, 2023 01:12
@tancik tancik merged commit 88b253f into nerfstudio-project:main Jun 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancik tancik tancik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maturk @tancik