Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for scannet dataset camera pose loading #2056

Merged
merged 3 commits into from
Jun 10, 2023
Merged

fix for scannet dataset camera pose loading #2056

merged 3 commits into from
Jun 10, 2023

Conversation

colin-de
Copy link
Contributor

@colin-de colin-de commented Jun 9, 2023 •
edited

for issue :#2054

It fixes the camera poses loaded before.
For Scannet scene scene0000_00.
Before:
image
Fix:
image

@colin-de colin-de mentioned this pull request Jun 9, 2023
Closed
@tancik
Copy link
Contributor

tancik commented Jun 10, 2023

Why does the reconstruction still look bad? Has it just not trained yet?

@colin-de
Copy link
Contributor Author

colin-de commented Jun 10, 2023 •
edited

its not trained yet.
The original dataloader let posed images upside down

tancik
tancik approved these changes Jun 10, 2023
View reviewed changes
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tancik tancik merged commit f2fdd10 into nerfstudio-project:main Jun 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancik tancik tancik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colin-de @tancik