colormaps: add "gray" #2058
Merged
colormaps: add "gray" #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
f-dy
commented
Jun 9, 2023
•
f-dy
commented
- Add the trivial "gray" colormap, useful to eg extract accumulation.
- Don't show "pca" in the viewer menu (it crashes the server)
- The "pca" choice didn't work when applied to a single-channel image (it crashed the viewer), and it's applied by default to any image of more than 3 channels, where the colormap choice is ignore anyway. - Add the trivial "gray" colormap, useful to eg extract accumulation.
f-dy
added a commit
to f-dy/nerfstudio
that referenced
this pull request
Jun 9, 2023
…d crop box Previously, ns-render interpolate: - ignored distortion parameters - used an interpolated focal length, but principal point was from the first camera - rendered all images with the same size, even if input views were of different sizes - forgot to render the last frame - There was no default support for crop box and background color, except when rendering from a camera path, where these would exclusively be fetched from the camera_path.json Now: - There is an command-line option `--fixed-intrinsics` to keep fixed intrinsics through the whole sequence, but they are all interpolated by default - Everything is interpolated, even size, so that `ns-render interpolate -step 1` should render exactly the input images - All render modes have the options `--use-bounding-box` `--background-color` `--bounding-box-min` `--bouding-box-max` (same syntax as ns-export), which can override the json settings when rendering a camera path. Works great with the gray colormap from nerfstudio-project#2058 to render object masks.
|
The |
f-dy
changed the title
|
@tancik I updated to re-add "pca" to the list, and fixed the viewer code to not show the "pca" option for single-channel images |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.