Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't force downscale factor to 1 for nerfacto-huge #2088

Merged
merged 2 commits into from
Jun 17, 2023
Merged

don't force downscale factor to 1 for nerfacto-huge #2088

merged 2 commits into from
Jun 17, 2023

Conversation

machenmusik
Copy link
Contributor

@machenmusik machenmusik commented Jun 16, 2023 •
edited

Fixes #2087.

@machenmusik
Copy link
Contributor Author

machenmusik commented Jun 16, 2023 •
edited

@SharkWipf can you try using this ?

per @kerrj forcing downscale factor to 1 was not necessary, so modifying nerfacto-huge instead of making yet another config

@machenmusik machenmusik changed the title nerfacto-lesshuge does not force downscale factor to 1 don't force downscale factor to 1 for nerfacto-huge Jun 16, 2023
kerrj
kerrj approved these changes Jun 17, 2023
View reviewed changes
Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@kerrj kerrj merged commit 1066f8f into nerfstudio-project:main Jun 17, 2023
4 checks passed
@SharkWipf
Copy link
Contributor

Yep, can confirm this fixed it for me, thanks!

lucasthahn pushed a commit to TNE-ai/nerfstudio that referenced this pull request Jun 20, 2023
@machenmusik @lucasthahn
don't force downscale factor to 1 for nerfacto-huge (nerfstudio-proje…
62b09d0 
…ct#2088)

* per @kerrj, nerfacto-huge doesn't need downscale_factor=1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerrj kerrj kerrj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Regression] Nerfacto-huge system memory usage went from 12GB to 175+GB (1200 images)
3 participants
@machenmusik @SharkWipf @kerrj