-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get_num_frames_in_video #2090
Conversation
What are you seeing as the output of ffprobe? I wan't to get a better idea about when it fails. |
Yes, in some cases ffprobe can give results like this: 123123\n\n123123. |
This doesn't work for me. I ran a test where it should return 635 frames, but it only returned 6. |
There was an error in the code: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tests have shown that there can be 2 exact same numbers in the output, separated by non-digit symbols. I think it's better to just find the first number.