Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkulhanek/colmap dataparser #2115

Merged
merged 6 commits into from
Jun 25, 2023
Merged

Jkulhanek/colmap dataparser #2115

merged 6 commits into from
Jun 25, 2023

Conversation

jkulhanek
Copy link
Contributor

This PR implements a dataparser to load the COLMAP sparse model directly without the need to run ns-process-data.

@jkulhanek
Copy link
Contributor Author

I think this dataparser can make it easier for users to use nerfstudio as ns-process-data is no longer required. Only the COLMAP model is sufficient. Currently, ns-process-data does three things:

  1. create colmap model
  2. downscale images
  3. export data as a json

If we accept this dataparser we can instead have a script that would only run colmap (for users which don't run it themselves).

This dataparser should be compatible with folders generated using ns-process-data (as they store the COLMAP model at the same paths). I would even go as far as suggest this as the default for nerfacto and other models. Let me know what you think.

Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkulhanek jkulhanek enabled auto-merge (squash) June 25, 2023 16:45
@tancik
Copy link
Contributor

tancik commented Jun 25, 2023

I think this dataparser can make it easier for users to use nerfstudio as ns-process-data is no longer required. Only the COLMAP model is sufficient. Currently, ns-process-data does three things:

  1. create colmap model
  2. downscale images
  3. export data as a json

If we accept this dataparser we can instead have a script that would only run colmap (for users which don't run it themselves).

This dataparser should be compatible with folders generated using ns-process-data (as they store the COLMAP model at the same paths). I would even go as far as suggest this as the default for nerfacto and other models. Let me know what you think.

Wouldn't this conflict with users that use non-colmap ns-process-data pipelines? It seems like many people use metashape or realitycapture.

@jkulhanek
Copy link
Contributor Author

I think this dataparser can make it easier for users to use nerfstudio as ns-process-data is no longer required. Only the COLMAP model is sufficient. Currently, ns-process-data does three things:

  1. create colmap model
  2. downscale images
  3. export data as a json

If we accept this dataparser we can instead have a script that would only run colmap (for users which don't run it themselves).
This dataparser should be compatible with folders generated using ns-process-data (as they store the COLMAP model at the same paths). I would even go as far as suggest this as the default for nerfacto and other models. Let me know what you think.

Wouldn't this conflict with users that use non-colmap ns-process-data pipelines? It seems like many people use metashape or realitycapture.

Yes, let’s keep the default then. I didn’t know many people used non colmap pipelines and it would make it more difficult for them.

@jkulhanek jkulhanek merged commit aa6c052 into main Jun 25, 2023
4 checks passed
@jkulhanek jkulhanek deleted the jkulhanek/colmap-dataparser branch June 25, 2023 17:08
@hdacnw
Copy link

hdacnw commented Jul 10, 2023

Found out that colmap dataparser only works with absolute path of the directory containing colmap outputs. Do you know where can I change for it to work with relative path? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants