allow ns-process-data to use CR2 raw images #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tancik
reviewed
Jun 24, 2023
|
Do others have non-Canon raw image samples that should also be supported? CR2 is one of the Canon suffixes, but others such as Nikon and Sony should work as well (in theory). |
|
Made it easy to add other suffixes to treat as raw images. |
machenmusik
added a commit
to machenmusik/nerfstudio
that referenced
this pull request
Jul 12, 2023
* allow ns-process-data to use CR2 raw images * Update process_data_utils.py * black wants an extra newline --------- Co-authored-by: Matias Turkulainen <30566358+maturk@users.noreply.github.com>
machenmusik
added a commit
to machenmusik/nerfstudio
that referenced
this pull request
Jul 12, 2023
* allow ns-process-data to use CR2 raw images * Update process_data_utils.py * black wants an extra newline --------- Co-authored-by: Matias Turkulainen <30566358+maturk@users.noreply.github.com>
machenmusik
added a commit
to machenmusik/nerfstudio
that referenced
this pull request
Jul 12, 2023
* allow ns-process-data to use CR2 raw images * Update process_data_utils.py * black wants an extra newline --------- Co-authored-by: Matias Turkulainen <30566358+maturk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note, this may allow other raw image formats to work as well, but I only have some CR2 that I can't share at present.)