Fix pickling of VanillaDataManager #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@assafbot, sorry, my bad. Can you please try again with the current version? |
|
Works! thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the VanillaDataManager impl. to make the classes truly generic.
It fixes #2102, #1868 (comment).
Note: it uses features available in Python>=3.8, it would totally break for older pythons.
When implementing #1868, we choose a simpler class_getitem impl. over the original implementation suggested in the first commit of #1868. But the simpler impl. breaks pickling support and causes errors in other places (restored yaml objects are not generic). This PR reverts the original implementation.