[WIP] torch.compile applied to ray sampling #2133
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On a simple scene without camera distortions, I am getting 166 train rays/s with torch compile vs 160 rays/s without -> roughly 4% speedup overall. |
tancik
reviewed
Jul 13, 2023
nerfstudio/utils/profiler.py
Outdated
There was a problem hiding this comment.
Are any of the changes here necessary?
There was a problem hiding this comment.
Not really, but tracing at the latter steps is a good idea. Should I undo the changes?
| @@ -526,15 +517,28 @@ def setup_eval(self): | |||
| num_workers=self.world_size * 4, | |||
| ) | |||
|
|
|||
| @torch.compile | |||
There was a problem hiding this comment.
use from nerfstudio.utils.misc import torch_compile?
| batch = self.train_pixel_sampler.sample(image_batch) | ||
| return self._next_train_compiled(image_batch) | ||
|
|
||
| @torch.compile |
|
Note: this is currently not ready for merging for the following reason: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies torch.compile to pixel sampling and ray generation.
We could theoretically see some speedup.
NOTE: I haven't tested all configurations.