Add option to render evaluated images #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tancik
reviewed
Jun 27, 2023
| @@ -173,7 +175,7 @@ def get_eval_image_metrics_and_images(self, step: int): | |||
|
|
|||
| @abstractmethod | |||
| @profiler.time_function | |||
| def get_average_eval_image_metrics(self, step: Optional[int] = None): | |||
| def get_average_eval_image_metrics(self, step: Optional[int] = None, output_path: Optional[Path]=None): | |||
| """Iterate over all the images in the eval dataset and get the average.""" | |||
| @@ -339,7 +341,7 @@ def get_eval_image_metrics_and_images(self, step: int): | |||
| return metrics_dict, images_dict | |||
|
|
|||
| @profiler.time_function | |||
| def get_average_eval_image_metrics(self, step: Optional[int] = None): | |||
| def get_average_eval_image_metrics(self, step: Optional[int] = None, output_path: Optional[Path] = None): | |||
auto-merge was automatically disabled
June 27, 2023 20:40
Head branch was pushed to by a user without write access
|
sorry for the delay here @tancik - this is now passing the build |
Thank you for your work. I encountered an error in nerfstudio (1.0.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an optional "render_output_path" parameter to the eval script that saves the rendered image outputs to the specified path.