Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/run_beta_viewer #2157

Merged
merged 7 commits into from
Jul 7, 2023
Merged

Feature/run_beta_viewer #2157

merged 7 commits into from
Jul 7, 2023

Conversation

Ilyabasharov
Copy link
Contributor

Done:

  • add --vis option with two cases: viewer and viewer_beta for ns-viewer script
    Example:
ns-viewer --load-config outputs/poster/nerfacto/2023-07-02_233032/config.yml --vis viewer_beta

Reason: #1660

tancik
tancik approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding

@Ilyabasharov
Copy link
Contributor Author

Also resolved #2162 by fixing data format for viewer. Default format was torch.float64 after converting from numpy

@Ilyabasharov Ilyabasharov requested a review from tancik July 7, 2023 21:26
@tancik tancik enabled auto-merge (squash) July 7, 2023 21:45
@tancik tancik merged commit b86a425 into nerfstudio-project:main Jul 7, 2023
4 checks passed
@OrangeSodahub
Copy link
Contributor

@tancik Hi, what's the difference between the viewer and viewer_beta?? Which one should I use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancik tancik tancik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ilyabasharov @OrangeSodahub @tancik @brentyi