Remove pytorch hash table if tcnn implementation is used #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjuxax
added a commit
to sjuxax/nerfstudio
that referenced
this pull request
Jul 13, 2023
This allows tcnn models that contained a torch hash_table to load. In particular, it allows us to load tcnn models prior to PR nerfstudio-project#2175. cf. nerfstudio-project#2175
tancik
added a commit
that referenced
this pull request
Jul 13, 2023
* Try non-strict model loading on RuntimeError. ... This allows tcnn models that contained a torch hash_table to load. In particular, it allows us to load tcnn models prior to PR #2175. cf. #2175 * Only allow non-strict loading when called with defaults. * Reflow to avoid code duplication; blacken. --------- Co-authored-by: Matthew Tancik <matt@lumalabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting tcnn implementation for HashEncoding, a PyTorch version was still initialized and held in memory, but never used. Now, the PyTorch hash table is only created when selecting PyTorch implementation, or if tcnn is not available.