Fix arguments that are not passed from config to NerfactoField #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good find! I think it makes sense to reset the nerfacto-big and huge configs so that the performance doesn't change (Im mostly worried about GPU memory). Later we can retune these values now that we know they will actually do something :) |
|
@tancik Thanks! Should I then update the configs and add it in this PR? |
|
That would be great! |
…acto-huge to default to match the original behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Models like
nerfacto-bigandnerfacto-hugeare changingbase_resandfeatures_per_levelin the config. However, the arguments are not actually passed to NerfactoField currently.