Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding input handling for RFFEncoding's get_out_dim(self) #2201

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Adding input handling for RFFEncoding's get_out_dim(self) #2201

merged 2 commits into from
Jul 11, 2023

Conversation

CardiacMangoes
Copy link
Contributor

Introduced handling in RFFEncoding for method get_out_dim(self) so that if self.include_input is True, the result adds the dimension of in_dim.

tancik
tancik approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tancik tancik enabled auto-merge (squash) July 11, 2023 22:48
@tancik tancik merged commit 6cb10ae into main Jul 11, 2023
4 checks passed
@tancik tancik deleted the RFFEncoding_get_out_dim_fix branch July 11, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancik tancik tancik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CardiacMangoes @tancik