-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast downscaling for video and image processing (PR2168 plus images) #2213
Merged
machenmusik
merged 13 commits into
nerfstudio-project:main
from
machenmusik:pr2168-plus-images
Jul 13, 2023
Merged
Fast downscaling for video and image processing (PR2168 plus images) #2213
machenmusik
merged 13 commits into
nerfstudio-project:main
from
machenmusik:pr2168-plus-images
Jul 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove code change from other branch.
tancik
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT. Thanks for update these cases
@SharkWipf thank you for #2168! |
SharkWipf
added a commit
to SharkWipf/nerfstudio
that referenced
this pull request
Jul 14, 2023
I did an oopsie and forgot a space in my final commit for nerfstudio-project#2168 / nerfstudio-project#2213 it seems, which breaks ffmpeg. This fixes that. My apologies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #2168 by accelerating downscaling for image processing, including polycam upscaled depth.