Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: get_normalized_directions #2216

Merged
merged 3 commits into from
Jul 14, 2023
Merged

refactor: get_normalized_directions #2216

merged 3 commits into from
Jul 14, 2023

Conversation

SauravMaheshkar
Copy link
Contributor

The get_normalized_directions and shift_directions_for_tcnn performed the same function but were placed in two separate files. This PR places them in base_field and refactors other usages.

@SauravMaheshkar SauravMaheshkar added quick fixes quality of life python Pull requests that update Python code labels Jul 13, 2023
@SauravMaheshkar SauravMaheshkar self-assigned this Jul 13, 2023
tancik
tancik approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to fix the test then it can be merged

@SauravMaheshkar
Copy link
Contributor Author

LGTM. Just need to fix the test then it can be merged

Fixed in 6ff033d

@SauravMaheshkar SauravMaheshkar merged commit 0cb98fb into main Jul 14, 2023
4 checks passed
@SauravMaheshkar SauravMaheshkar deleted the saurav/refactor-field branch July 14, 2023 00:14
@dberga dberga mentioned this pull request Jul 21, 2023
Closed
@Yukun66 Yukun66 mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancik tancik tancik approved these changes

@terrancewang terrancewang Awaiting requested review from terrancewang

Assignees

@SauravMaheshkar SauravMaheshkar

Labels
python Pull requests that update Python code quality of life quick fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SauravMaheshkar @tancik