Render VR180 video #2261
Merged
Render VR180 video #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the VR180 camera model to render VR180 video and images. I condensed the omnidirectional stereo and VR180 render post processing in the render script. I have updated the documentation for VR180 support.
tancik
reviewed
Jul 23, 2023
nerfstudio/cameras/camera_paths.py
Outdated
Comment on lines
157
to
161
| camera_type == CameraType.EQUIRECTANGULAR | ||
| or camera_type == CameraType.OMNIDIRECTIONALSTEREO_L | ||
| or camera_type == CameraType.OMNIDIRECTIONALSTEREO_R | ||
| or camera_type == CameraType.VR180_L | ||
| or camera_type == CameraType.VR180_R |
There was a problem hiding this comment.
Can you condense this to
`if camera_type in [CameraType.EQUIRECTANGULAR, ...]
There was a problem hiding this comment.
Sounds good, I have updated the formatting.
Condensing the if statement for camera type intrinsics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the VR180 camera model to render VR180 video and images. I condensed the omnidirectional stereo and VR180 rendering post processing in the render script. I have updated the documentation for VR180 support as well as the Blender documentation since VR180 rendering is compatible with the Blender add-on.