Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct pixel area in volumetric sampler #2268

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

hturki
Copy link
Contributor

@hturki hturki commented Jul 26, 2023

The existing volumetric sampler code returns 0 as the pixel areas. This PR returns the correct values instead.

Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tancik tancik merged commit 4d80f0c into nerfstudio-project:main Jul 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants