Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust install instructions #2277

Merged
merged 2 commits into from
Aug 1, 2023
Merged

More robust install instructions #2277

merged 2 commits into from
Aug 1, 2023

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Jul 28, 2023

I just tried an installation on a fresh Ubuntu 22.04 machine, with no system-level CUDA installation.

Unsurprisingly (and as mentioned by @kpertsch), the tiny-cuda-nn install step fails without cuda-toolkit installed. Running the extra install for cuda-toolkit fixes it. I think we should add it to the setup instructions.

A few bits of uncertainty before merging:

  • Will a system-level CUDA install break anything here?
  • Possibly related: a few people have mentioned needing to fuss with environment variables for all of the linking etc to work. I've never needed to, what's expected here?
  • @kpertsch also reported needing to update gcc via conda install -c conda-forge gcc=11.2 gxx=11.2. We may want to add this to the FAQ.
  • Perhaps we should add a note about supported NVIDIA driver versions? The current state of which NVIDIA drivers are compatible which CUDA versions is not entirely clear even to myself... (can a driver be "too new" for CUDA 11.7 etc)

@maturk
Copy link
Collaborator

maturk commented Jul 28, 2023

I have found that conda installing cuda-toolkit automatically sets correct Cuda home and other environment variables in a local conda env. I think this is a good addition to the instructions and I have personally seen this issue pop up multiple times in the Discord and conda installing has always fixed it, even if you already have system level cuda installed.

@kerrj
Copy link
Collaborator

kerrj commented Aug 1, 2023

Trying this on a new machine, installation fails on python 3.11 since open3d isn't supported on it yet. Might want to specify >=3.8 and <3.11 in the instructions

@kerrj
Copy link
Collaborator

kerrj commented Aug 1, 2023

3.10 works for me

Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes SGTM as long as they pass doc checks etc, I only tested the instructions themselves not the website layout etc

@brentyi brentyi enabled auto-merge (squash) August 1, 2023 20:19
@brentyi brentyi merged commit dab39c2 into main Aug 1, 2023
4 checks passed
@brentyi brentyi deleted the brent/install_instructions branch August 1, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants