Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow custom user ID #2334

Merged
merged 2 commits into from
Aug 12, 2023
Merged

Conversation

yurkovak
Copy link
Contributor

A fix for #1130. It's not possible to write into a volume with a wrong user making it more hassle to train.

Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tancik tancik enabled auto-merge (squash) August 12, 2023 20:04
@tancik tancik merged commit c599d0f into nerfstudio-project:main Aug 12, 2023
4 checks passed
@Ilyabasharov
Copy link
Contributor

Duplicate of prev PR. Current pr works not all cases.

This was referenced Aug 17, 2023
@XinyueZ
Copy link

XinyueZ commented Aug 30, 2023

The PR has problem.
I was trying to build the container after merged (current main), I got error:

 > [ 6/22] RUN useradd -m -d /home/user -g root -G sudo -u ${USER_ID} user:                                                                                                                                            
#0 0.447 useradd: invalid user ID 'user'                                                                                                                                                                               
------                                                                                                                                                                                                                 
Dockerfile:103                                                                                                                                                                                                         
--------------------
 101 |     
 102 |     # Create non root user and setup environment.
 103 | >>> RUN useradd -m -d /home/user -g root -G sudo -u ${USER_ID} user
 104 |     RUN usermod -aG sudo user
 105 |     # Set user password

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants