Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viser 0.1.0, fix type checker errors #2343

Merged
merged 3 commits into from
Aug 15, 2023
Merged

viser 0.1.0, fix type checker errors #2343

merged 3 commits into from
Aug 15, 2023

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Aug 15, 2023

The latest release of viser renames GuiHandle to GuiInputHandle, since there are now non-input GUI handles. I added a shim so it shouldn't produce any runtime errors (and/or actually break any nerfstudio installations), but it's hidden to the type checker and will produce a pyright error.

Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brentyi brentyi enabled auto-merge (squash) August 15, 2023 22:52
@brentyi brentyi merged commit 6d51af1 into main Aug 15, 2023
4 checks passed
@brentyi brentyi deleted the brent/viser_0.1.0 branch August 15, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants