Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ARG before FROM bug #2371

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Conversation

padeler
Copy link
Contributor

@padeler padeler commented Aug 25, 2023

ARG commands before FROM are not visible inside the build unit (after the FROM) unless specified again without default values.

Dockerfile will not build without this fix.

Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tancik tancik enabled auto-merge (squash) August 31, 2023 21:48
@tancik tancik merged commit a121d76 into nerfstudio-project:main Aug 31, 2023
4 checks passed
maturk pushed a commit that referenced this pull request Sep 11, 2023
Fixes ARGS before FROM bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants