NERFSTUDIO_METHOD_CONFIGS callable MethodSpecification #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks nice. Whats missing now is a way to let users know about this functionality, at the moment it is quite buried. Any ideas on a good place in the docs to add it? |
|
Does extending new_methods docs to note compatibility of NERFSTUDIO_METHOD_CONFIGS with a function or derived class work? |
Yep! sounds good. |
|
@tancik - docs added |
drewgilliam
force-pushed
the
method_spec
branch
from
82413f2
to
c7fbc1f
Compare
maturk
pushed a commit
that referenced
this pull request
Sep 11, 2023
* NERFSTUDIO_METHOD_CONFIGS allow method specification as callabale (function or class) * docs - NERFSTUDIO_METHOD_CONFIGS accepts function or derived class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
NERFSTUDIO_METHOD_CONFIGSenvironment variable to reference callableMethodSpecificationsuch as a function or class. Allowable references would now include:MethodSpecificationinstance (current functionality)MethodSpecificationinstanceMethodSpecificationThis allows the custom model instantiation to be delayed until registration, rather than requiring instantiation immediately on import of the python module containing the model.