Fix benchmarking: apply get_background_color in renderer and set profiler to none #2397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
./nerfstudio/scripts/benchmarking/launch_train_blender.sh -m nerfacto
failed because of two errors:logging.enable-profiler
is does not exist and thebackground_color
can be a string likewhite
.This pull request fixes both issues.
Note: the original code mentioned:
# This case must be before the others or the override is not properly applied
I moved that case to become the final one, but as they are all still separated by an if - else clause, I don't think it breaks any assumptions.
A further comment related to benchmarking: Would it be possible to add benchmark results somewhere in this repo/documentation along with the last commit/stable release the benchmark was run on? This would let anyone use benchmark results without having to recompute them, as long as they are on the same code base.