Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify dataparser and method discovery #2398

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

jkulhanek
Copy link
Contributor

No description provided.

@jkulhanek jkulhanek force-pushed the jkulhanek/external-dataparser-registration branch 2 times, most recently from 436de59 to d835dc6 Compare September 6, 2023 12:06
@brentyi
Copy link
Collaborator

brentyi commented Sep 7, 2023

Consistency here makes sense to me. I guess we'd also want to update the docs?

@jkulhanek
Copy link
Contributor Author

I have updated the docs.

@jkulhanek jkulhanek force-pushed the jkulhanek/external-dataparser-registration branch from d835dc6 to b468c7c Compare September 7, 2023 06:49
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkulhanek jkulhanek enabled auto-merge (squash) September 8, 2023 08:09
@jkulhanek jkulhanek merged commit 6af0bcf into main Sep 8, 2023
4 checks passed
@jkulhanek jkulhanek deleted the jkulhanek/external-dataparser-registration branch September 8, 2023 08:26
maturk pushed a commit that referenced this pull request Sep 11, 2023
* Unify external dataparser registration

* Unify dataparser and method discovery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants