Fix the problem that camera will be freezed when moving forward #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maturk
pushed a commit
that referenced
this pull request
Sep 11, 2023
* fix camera freezed when moving forward * simplify code --------- Co-authored-by: Matthew Tancik <matt@lumalabs.ai>
|
I ran into this a lot, thank you so much for fixing!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In the web viewer, rotate up/down via mouse drage not work when pressing
w:2023-09-07.21-48-37.mp4
and the camera will be freezed after pressing
wfor a while:2023-09-07.21-08-36.mp4
Current implementation will led to
position===target: https://stackoverflow.com/questions/47503286/why-do-three-js-trackball-controls-freeze-if-camera-position-controls-targetThis modification can fix these problems:
2023-09-07.21-47-29.mp4
2023-09-07.21-32-04.new.mp4