Fix issue when extracting all frames from a video. #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maturk
pushed a commit
that referenced
this pull request
Sep 11, 2023
* Remove superfluous num_frames * process_data video: Always use -vsync vfr, even when extracting all images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should always be using
-vsync vfr, even when extracting all frames.Not doing so results in many times more frames extracted than we expect (i.e. 37891 vs 4143 in my case), and they're not even "real" useful frames.
Not something you would normally run into if you're doing things right, but in doing some A/B testing of different methods of preprocessing, I ran into it anyway.