Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colmap parser: fix downscale for complex paths #2425

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Colmap parser: fix downscale for complex paths #2425

merged 1 commit into from
Sep 13, 2023

Conversation

jkulhanek
Copy link
Contributor

This PR makes the following changes to the colmap dataparser:

  • Optional paths are relative to config.data
  • Fixes downscaling for depth/mask data
  • Downscale respects deep image paths (previously it would fail with more then 1 level)

@jkulhanek jkulhanek enabled auto-merge (squash) September 13, 2023 14:01
tancik
tancik approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkulhanek jkulhanek merged commit e9330d5 into main Sep 13, 2023
4 checks passed
@jkulhanek jkulhanek deleted the jkulhanek/colmap-fix-downscale-for-complex-paths branch September 13, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancik tancik tancik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkulhanek @tancik