Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import error when tcnn installed but CUDA runtime not available #2429

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

jkulhanek
Copy link
Contributor

Also, this enables the ns-install-cli to work inside docker build context without requiring cuda-docker-runtime

@jkulhanek
Copy link
Contributor Author

The change to the dockerfile also depends on fixing the import errors in lerf and nerfplayer:
kerrj/lerf#48
lsongx/nerfplayer-nerfstudio#9
Since these are included in the official image.

Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer

@jkulhanek jkulhanek enabled auto-merge (squash) September 15, 2023 16:20
@jkulhanek jkulhanek merged commit ef2fd3d into main Sep 15, 2023
4 checks passed
@jkulhanek jkulhanek deleted the jkulhanek/tcnn-cuda-optional branch September 15, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants