Allow the option for timestamp to be generated for ns-train --load-config
#2442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
ns-train --load-config $CONFIG_PATH
currently the timestamp is fixed to what was in the config file, which is probably fine. But when I omit thetimestamp
parameter from the config file, it would be nice to have a new timestamp be set. Instead, the current implementation leaves the timestamp value as the default string value "{timestamp}" instead of a new valid timestamp.I believe we can fix this with a single line change, by moving the call to
config.set_timestamp()
to after loading the config file. I don't see how this will impact anything else.This won't affect people who want their timestamp fixed to what the config file reads because
config.set_timestamp()
only sets the value if it is set to the default value "{timestamp}" due to the if statement here:nerfstudio/nerfstudio/configs/experiment_config.py
Lines 97 to 100 in ef2fd3d
I think this behavior is probably was what was intended originally but got lost overtime.
I have tested this locally on an ubuntu computer.
Please consider this PR
Cheers