-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add share link support for beta viewer #2445
Conversation
This is very cool! Could we add the share link to the rich table instead of as new line? |
This is what I had originally; the reason I switched it is that the share link can take a second or two to generate. I can flip it back in
|
Eventually I kinda want to make the share option opt-out and have it front and center in the table. I wasn't aware that it had a lag, though a couple of seconds is pretty short. Thoughts? |
Okay, let's include it in the table! I can add it to the viser to-do list. I just measured the delay and it's much faster now, ~0.15 seconds, so this is possibly a non-issue. It probably helps that I'm on Ethernet now. |
IMO we should rename "share" in the config to something like "public-viewer" or something more descriptive |
I'm okay with something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Thank you very much for your work. I use: C:\Users\zzl\erfstudio\outputs\kitchen\erfacto\2024-01-25_131124\config.yml --vis viewer_ Beta When I use ns viewer -- load configuration C:\Users\zzl\erfstudio\outputs\kitchen\erfacto\2024-01-25_131124\config.yml --vis viewer_ Beta --viewer.make-share-url True. I can obtain new connections and open it Does this mean that --viewer.make-share-url is an effective solution to my problem? |
Hi! It's currently a known bug that some browsers cannot recognize the 0.0.0.0 url. You can try manually typing in http://localhost: followed by the port that viser spits out into your browser, or you can try to utilize the shared link feature if that doesn't work. |
This PR adds initial support for shareable links to the beta viewer.
Link generation can be enabled via
--share True
on eitherns-train
orns-viewer
. For example,wil print:
Which, thanks @jonahbedouch's efforts on mobile support, we can open on a phone!
An example URL is https://edge-based-relational-7462.share.viser.studio, which I'll keep up for a few hours if anybody wants to check that they can access it.
Once the final beta viewer features are stable, this can also help with Colab tunnel issues + various port forward-related roadblocks that folks seem to be having (#1908 #2433 #2439).