Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render oriented crops in viewer beta #2447

Merged
merged 7 commits into from
Sep 19, 2023
Merged

Render oriented crops in viewer beta #2447

merged 7 commits into from
Sep 19, 2023

Conversation

kerrj
Copy link
Collaborator

@kerrj kerrj commented Sep 19, 2023

Adds support for for rendering with oriented boxes in the new viewer.

image

2023-09-19-14-41-44.mp4

Copy link
Collaborator

@brentyi brentyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's fix the formatting?

nerfstudio/viewer_beta/render_panel.py Outdated Show resolved Hide resolved
@kerrj kerrj merged commit e0d8f04 into main Sep 19, 2023
4 checks passed
@kerrj kerrj deleted the justin/render_obb branch September 19, 2023 23:48
@smart4654154
Copy link

Thank you very much for your work. My question seems to be related to this job. What is the meaning of the crop scale value in the new version of viewer? I found that the value of the crop scale cannot match the coordinate values of the world coordinate system. For example, when the crop scale is set to 4, 4, 4, it is approximately equivalent to a square with a side length of 40 in the world coordinate system
image
What are the meanings of "crash max" and "crash min" in Viewer_legacy?
image

@brentyi
Copy link
Collaborator

brentyi commented Mar 11, 2024

let's move discussion to #1606!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants