Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of using both Comet and Viewer at the same time #2488

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

Lothiraldan
Copy link
Contributor

In our previous PR #2431, we forgot to update the is_viewer_enabled function, causing an issue where Comet and the Viewer could not be used simultaneously. This issue has now been resolved. Additionally, I took the opportunity to slightly refactor the function, making it easier to update in the future.

@tancik tancik merged commit a484d25 into nerfstudio-project:main Oct 4, 2023
4 checks passed
@Lothiraldan Lothiraldan deleted the Lothiraldan-patch-1 branch October 5, 2023 09:29
@sherpan
Copy link
Contributor

sherpan commented Nov 7, 2023

@tancik just curious when the next release is?

@tancik
Copy link
Contributor

tancik commented Nov 7, 2023

It will be post CVPR. We are planning to package the new viewer and gaussian splatting into the release so it's a bit larger than normal.

@sherpan
Copy link
Contributor

sherpan commented Nov 8, 2023

Thanks @tancik. So next Summer 2024 is the next release? Or did you by chance mean Neurips in December?

@brentyi
Copy link
Collaborator

brentyi commented Nov 8, 2023

It'll be this year. 🙂

After CVPR meant after the deadline, which most of the core team/maintainers are currently tied up with!

The paper deadline is 11/17 and the supplementary is 11/26.

@sherpan
Copy link
Contributor

sherpan commented Jan 8, 2024

hi @brentyi just curious what the current timelines are for the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants