Integrate scene click capability from original viewer #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original viewer, a user could click on a point in the screen, to specify a "ray"-like interaction (akin to a pointer finger stick originating from the client camera, going through the clicked pixel on the image plane).
This replicates the original capability in viewer_beta, with a few differences:
unregister_click_cb)ViewerClicks) inside a function that takes as inputScenePointerEvent, for viser-nerfstudio compatibility.(Implementation based on the recently integrated viser PR nerfstudio-project/viser#106)