Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix datamanagers' get_rays_per_batch functions in case of using DynamicBatchPipeline #2522

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Fix datamanagers' get_rays_per_batch functions in case of using DynamicBatchPipeline #2522

merged 2 commits into from
Oct 16, 2023

Conversation

sjj118
Copy link
Contributor

@sjj118 sjj118 commented Oct 13, 2023

This correct the "Train Rays / Sec" when using DynamicBatchPipeline

kerrj
kerrj approved these changes Oct 15, 2023
View reviewed changes
Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@tancik tancik merged commit ce06935 into nerfstudio-project:main Oct 16, 2023
4 checks passed
@sjj118 sjj118 deleted the patch-1 branch October 16, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerrj kerrj kerrj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjj118 @kerrj @tancik