Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradient scaling option to more methods #2555

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

kobejean
Copy link
Contributor

Here is a proposal to add gradient scaling as an option to other methods like instant-ngp, mipnerf, tensorf, vanilla-nerf. It is disabled by default so it won't change existing behaviour. The code was copied from the nerfacto method.

Copy link
Collaborator

@brentyi brentyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@brentyi brentyi merged commit e4a0050 into nerfstudio-project:main Oct 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants