Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metashape_utils: work with camera groups #2626

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

f-dy
Copy link
Contributor

@f-dy f-dy commented Nov 22, 2023

Metashape XML parsing was broken when it contained camera groups.
I changed the way it iterates over XML elements to iterate over elements of a given type (camera) rather than on all children of the selected node.

Fixes #2625

Copy link
Collaborator

@jb-ye jb-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple fix, lgtm.

@jb-ye jb-ye enabled auto-merge (squash) April 30, 2024 20:15
@jb-ye jb-ye merged commit e232227 into nerfstudio-project:main Apr 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metashape import: camera groups not handled
2 participants