Keyframe timing for beta viewer #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cleaned up the spline rendering a little bit1 and added spherical 2 handles for transitions, which you can click on to adjust timing between keyframes.
Here's an example workflow, where we make the transition between a pair of keyframes faster:
keyframes_actual.mp4
As an aside: the render panel code is adapted from research code and really chaotic. I spent a little bit of time trying to refactor and couldn't come up with something I was super happy with; I'd like to revisit this from viser in a "recommended usage patterns" kind of way.
Footnotes
via https://github.com/nerfstudio-project/viser/pull/77, thanks @origamiman72! ↩
via https://github.com/nerfstudio-project/viser/pull/132, thanks @pritzza! ↩