Trainer can now always save dataparser transform #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentyi
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base_dataparser now has a base
save_dataparser_transform()methodnerfstudio/nerfstudio/data/dataparsers/base_dataparser.py
Line 77 in 64f0b25
I think this might have just been a clean-up item that either didn't get addressed in the earlier PR https://github.com/nerfstudio-project/nerfstudio/pull/1008/files#r1207121018
or likely something else got refactored and this got missed. The current guard is too restrictive now. If we want to maintain a guard, probably better to do a
hasattronself.pipeline.datamanager.train_dataparser_outputsfor duck-typing. If for some reason users are not supposed to subclass from the base data parser? idk.Not sure if there are unit tests that can look for this file?