Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

important fix typo #2800

Merged
merged 1 commit into from
Jan 20, 2024
Merged

important fix typo #2800

merged 1 commit into from
Jan 20, 2024

Conversation

jb-ye
Copy link
Collaborator

@jb-ye jb-ye commented Jan 20, 2024

We have --cull_alpha_thresh and --cull_scale_thresh, they are very different ...

@jb-ye
Copy link
Collaborator Author

jb-ye commented Jan 20, 2024

@kerrj @brentyi @tancik Could you help merge it quickly?

kerrj
kerrj approved these changes Jan 20, 2024
View reviewed changes
Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops good catch!

@kerrj kerrj merged commit 8952fb5 into nerfstudio-project:main Jan 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerrj kerrj kerrj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jb-ye @kerrj