Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update splatfacto.py #2804

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Update splatfacto.py #2804

merged 2 commits into from
Jan 23, 2024

Conversation

Harr7y
Copy link
Contributor

@Harr7y Harr7y commented Jan 22, 2024

Shape error: The shape of batch['mask'] is [H, W, 1], not[H, W]

Shape error: The shape of batch['mask'] is [H, W, 1], not[H, W]
@brentyi
Copy link
Collaborator

brentyi commented Jan 22, 2024

Thanks for the fix!

Just to confirm: what kind of data are you getting HxWx1 masks from? Do you know where in the code these are generated?

It looks like this error is my fault; I added the assertion in #2785, where I'm also creating HxW masks.

cc also @f-dy

@f-dy
Copy link
Contributor

f-dy commented Jan 22, 2024

I haven't tested the latest mask changes yet (we'll be doing it soon)

@Harr7y
Copy link
Contributor Author

Harr7y commented Jan 23, 2024

Thanks for the fix!

Just to confirm: what kind of data are you getting HxWx1 masks from? Do you know where in the code these are generated?

It looks like this error is my fault; I added the assertion in #2785, where I'm also creating HxW masks.

cc also @f-dy

I used the bear data mentioned in nerf2nerf. The mask was generated by myself, a picture with a black center and white sides. full_images_datamanager is used, and I think the code used for generating the mask should at https://github.com/nerfstudio-project/nerfstudio/blob/main/nerfstudio/data/utils/data_utils.py#L25.

@Tao-11-chen
Copy link
Contributor

Hi, the same situation for me, it should be merged.

Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! @brentyi it looks like the rest of the repo expects HxWx1, so we should probably change aria to be consistent with that. see https://github.com/nerfstudio-project/nerfstudio/blob/main/nerfstudio/data/utils/data_utils.py#L25

@kerrj kerrj merged commit b669f51 into nerfstudio-project:main Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants