Make downloading more windows-friendly #2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cr333
reviewed
Jan 23, 2024
| @@ -143,10 +144,10 @@ def download_capture_name(save_dir: Path, dataset_name: str, capture_name: str, | |||
| file_id_or_zip_url = capture_name_to_file_id[capture_name] | |||
| if file_id_or_zip_url.endswith(".zip"): | |||
| url = file_id_or_zip_url # zip url | |||
| target_path = str(save_dir / f"{dataset_name}/{capture_name}") | |||
| target_path = str(save_dir / f"{dataset_name}" / f"{capture_name}") | |||
There was a problem hiding this comment.
Consider simplifying this and other similar changes:
Suggested change
| target_path = str(save_dir / f"{dataset_name}" / f"{capture_name}") | |
| target_path = str(save_dir / dataset_name / capture_name) |
There was a problem hiding this comment.
Oops, midnight brain wasn't thinking too hard. I'll fix this.
VasuAgrawal
force-pushed
the
vasu-windows-download
branch
from
5faada3
to
bd0ac70
Compare
|
Fixed. Also rebased the changes to be on top of master again. |
brentyi
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a few issues while running the various download commands on my Windows box. This diff attempts to remedy those issues. In no particular order:
os.systemtosubprocess.runcalls, which have better handling of'vs"and other shell escapes. In particular, the'which were previously used (line 431) weren't working in CMD, which is used byos.systemon my machine. They work fine in powershell, though.curlcall to use-oflag to directly output to file, rather than going through IO redirection..temp. This allows multiple download jobs to run concurrently, since they're typically rate-limited by the upstream.