Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing colmap installation to use apt-get since gdown on the URL unable to download colmap #2823

Conversation

AntonioMacaronio
Copy link
Contributor

@AntonioMacaronio AntonioMacaronio commented Jan 25, 2024

in the demo colab notebook, gdown is unable to install colmap because the gdrive link is not sharable or not available.

This issue is also mentioned here:

  1. https://github.com/nerfstudio-project/nerfstudio/pull/2787/files
  • !conda install -c conda-forge colmap will raise a PackagesNotFoundError.
  1. Colmap binary link in Colab is invalid #2406 (comment)
  • the fix mentioned here will also have a PackagesNotFoundError and then the runtime always crashes/restarts

To download colmap, using apt-get solved these issues and allowed me to process my data in the following cell - it is a quick one-line and it takes about 4minutes 16seconds to install nerfstudio and its dependencies

Copy link
Contributor

@ginazhouhuiwu ginazhouhuiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ginazhouhuiwu ginazhouhuiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@brentyi brentyi enabled auto-merge (squash) January 25, 2024 23:04
@brentyi
Copy link
Collaborator

brentyi commented Jan 25, 2024

I think that the apt version of colmap isn't GPU-accelerated, so maybe still revisiting again before #2787 is merged?

@brentyi brentyi merged commit 1aba4ea into nerfstudio-project:main Jan 25, 2024
2 checks passed
@ginazhouhuiwu
Copy link
Contributor

Will definitely do!

@ginazhouhuiwu
Copy link
Contributor

I think for now if it patches the issue (which it seem to do), can be merged in main. I personally didn't run into problems with conda install so I have to look into it more and see what the discrepancy is.

@brentyi
Copy link
Collaborator

brentyi commented Jan 25, 2024

Sounds good! I think missing GPU support in colmap is possibly also fine if it makes the install much easier. We could maybe benchmark.

@machenmusik
Copy link
Contributor

I would recommend benchmarking, as my recollection of colmap non-GPU on larger datasets was... significantly slower execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants