Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2843 - safer typing #2848

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix #2843 - safer typing #2848

merged 1 commit into from
Jan 30, 2024

Conversation

jkulhanek
Copy link
Contributor

#2843

@brentyi Implements suggested changes.

@jkulhanek jkulhanek enabled auto-merge (squash) January 30, 2024 10:45
@jkulhanek jkulhanek force-pushed the jkulhanek/add-use-appearance-embeding-flag branch from 4d3c475 to 27ff80a Compare January 30, 2024 10:58
@jkulhanek jkulhanek force-pushed the jkulhanek/add-use-appearance-embeding-flag branch from 27ff80a to 4fbad61 Compare January 30, 2024 11:11
brentyi
brentyi approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@brentyi brentyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊 🎊 🎊

@jkulhanek jkulhanek merged commit 3a90cb5 into main Jan 30, 2024
2 checks passed
@jkulhanek jkulhanek deleted the jkulhanek/add-use-appearance-embeding-flag branch January 30, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentyi brentyi brentyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkulhanek @brentyi