Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless call to .with_suffix(""), which causes a bug if filename contains dots #2882

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Remove useless call to .with_suffix(""), which causes a bug if filename contains dots #2882

merged 2 commits into from
Feb 7, 2024

Conversation

f-dy
Copy link
Contributor

@f-dy f-dy commented Feb 7, 2024

Fixes #2881

kerrj
kerrj approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kerrj kerrj merged commit 66e1194 into nerfstudio-project:main Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerrj kerrj kerrj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ns-render dataset removes too much from the filename
2 participants
@f-dy @kerrj