Fix an issue where gradient accumulation could not be passed as argument due to a type error. #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent due to a type error.
brentyi
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
looks great, thanks @SharkWipf!!
cc @kerrj for issue on gradient accumulation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discord (Thanks Brent),
--gradient-accumulation-stepsdid not properly cast its values to int and would error because it received a string.There is still a separate bug where specifying
camera_opton nerfacto will cause an error, and the documentation on the --gradient-accumulation-steps could be better (accepted values are currentlyproposal_networks,fieldsandcamera_opts, but there's no way to figure this out without without diving into the code AFAICT), but that's for another time/person/PR.