Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash when both mask and downscale_factor are set #2920

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

jinhwanlazy
Copy link
Contributor

Splatfacto crashes when mask is exist and num_downscale > 0, because downscale has not been applied to mask.

@jb-ye
Copy link
Collaborator

jb-ye commented Feb 16, 2024

Thanks for the catch. It looks good to me.

May I ask when you found num_downscale > 0 useful? I set it to zero because I didn't observe any benefits of that and the official Inria GS doesn't do it either.

@jinhwanlazy
Copy link
Contributor Author

I found no big difference in the end results, but it makes first training iterations sigificantly faster. So I think it like, why not?

@jb-ye
Copy link
Collaborator

jb-ye commented Feb 19, 2024

I found no big difference in the end results, but it makes first training iterations sigificantly faster. So I think it like, why not?

Okay, I agree this is a bug to be fixed.

Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kerrj kerrj enabled auto-merge (squash) February 20, 2024 17:18
@kerrj kerrj merged commit fee8ab7 into nerfstudio-project:main Feb 21, 2024
2 checks passed
@jinhwanlazy jinhwanlazy deleted the rick/bugfix branch February 21, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants